Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-oracle: managed connection and queries #2906

Closed
antoniivanov opened this issue Nov 15, 2023 · 0 comments · Fixed by #2927
Closed

vdk-oracle: managed connection and queries #2906

antoniivanov opened this issue Nov 15, 2023 · 0 comments · Fixed by #2927
Assignees
Labels
story Task for an Epic
Milestone

Comments

@antoniivanov
Copy link
Collaborator

antoniivanov commented Nov 15, 2023

We want to support managed connection against oracle database. That means that queries against oracle can be executed using any of VDK interfaces : vdk sql-query, job_input.execute_query, SQL steps and so on.

What needs to be done is

The https://github.com/vmware/versatile-data-kit/blob/feature/vdk-oracle/projects/vdk-plugins/vdk-oracle is already bootstrapped here. So it's a starting point.

  1. Expose the configuration options needed for oracle. You can use the DuckDB as a reference example and add the definitions as here
  2. Register the new connection type like this : https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-duckdb/src/vdk/plugin/duckdb/duckdb_plugin.py#L34
  3. Write a function test that executes a data job with SQL steps and python step (job_input.execute_query) similarly to the way it was done here https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-duckdb/tests/test_plugin.py#L36 (ignore the ingestion part of the test. Those should have been split anyway)
  4. Update the README.md of the plugin as appropriate.
@DeltaMichael DeltaMichael added this to the VDK Oracle milestone Nov 22, 2023
@DeltaMichael DeltaMichael added the story Task for an Epic label Nov 22, 2023
@DeltaMichael DeltaMichael linked a pull request Nov 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Task for an Epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants