fixed race condition and memory leak in docker stats #4550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. This change fixes that issue as well as increases the unit testing coverage. Fixes vmware#4549
sgairo
approved these changes
Apr 4, 2017
|
LGTM |
jzt
approved these changes
Apr 4, 2017
|
This doesn't fix the issue...will close and open a future PR containing fix for race and #4421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases a race could be encountered when executing docker
stats. The race would result in an orphaned go routine that
would be a memory leak. This change fixes that issue as well
as increases the unit testing coverage.
Fixes #4549