docker stats integration tests #4421
Assignees
Labels
area/docker
Support for the Docker operations
component/test
Tests not covered by a more specific component label
priority/p0
Milestone
Comments
mhagen-vmware
added
the
component/test
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 6, 2017
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 6, 2017
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 6, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 8, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 8, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
|
This was merged and fixed into the docker 1.13 PR. |
|
@mhagen-vmware I don't see where this was merged -- do you have a commit that includes the stats integration tests? |
|
sorry good catch, I thought you said it was in Jake's PR, but it is not. Why is you PR closed then? Should you reopen and merge now? |
|
I mistakenly closed it..I'll reopen in a bit...but the stats work is now waiting on #4653 -- stats needs the 1.13 client AND the most recent version of govc (0.14) |
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 10, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 10, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 13, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 13, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 13, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this issue
Apr 14, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
matthewavery
pushed a commit
to matthewavery/vic
that referenced
this issue
May 3, 2017
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User statement: As a user of VIC, I want to know that docker stats functionality has been fully tested so that I can have confidence in it's behavior.
Details: Create integration tests for the docker stats functionality represented in #4413 -- CPU and Memory.
Acceptance criteria:
Tests defined and running in either CI or nightly.
The text was updated successfully, but these errors were encountered: