Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker stats race condition #4549

Closed
cgtexmex opened this issue Apr 4, 2017 · 0 comments
Closed

docker stats race condition #4549

cgtexmex opened this issue Apr 4, 2017 · 0 comments
Assignees
@cgtexmex
Labels
area/docker Support for the Docker operations priority/p0
Milestone
Sprint 7

Comments

@cgtexmex
Copy link
Contributor

cgtexmex commented Apr 4, 2017

When executing docker stats the VCH appliance might encounter a race condition that would orphan a go routine. This orphaned routine would never be garbage collected resulting in a memory leak.
@cgtexmex cgtexmex added area/docker Support for the Docker operations priority/p0 labels Apr 4, 2017
@cgtexmex cgtexmex added this to the Sprint 6 milestone Apr 4, 2017
@cgtexmex cgtexmex self-assigned this Apr 4, 2017
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 4, 2017
fixed race condition and memory leak in docker stats
45a2a65 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak. This change fixes that issue as well
as increases the unit testing coverage.

Fixes vmware#4549
@cgtexmex cgtexmex mentioned this issue Apr 4, 2017
Closed
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 5, 2017
fixed race and added support for all option in docker stats
e2894e2 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
@cgtexmex cgtexmex mentioned this issue Apr 5, 2017
Closed
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
Fixed race and added support for all option in docker stats
25a1c4b 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
Fixed race and added support for all option in docker stats
8886012 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
Fixed race and added support for all option in docker stats
c3b775f 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
Fixed race and added support for all option in docker stats
713732e 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
Fixed race and added support for all option in docker stats
be54b83 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 8, 2017
Fixed race and added support for all option in docker stats
ac21016 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 8, 2017
Fixed race and added support for all option in docker stats
3552ce2 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 10, 2017
Fixed race and added support for all option in docker stats
3e5fa1a 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
@cgtexmex cgtexmex mentioned this issue Apr 10, 2017
Merged
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 10, 2017
Fixed race and added support for all option in docker stats
7308f25 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
@mhagen-vmware mhagen-vmware modified the milestones: Sprint 6, Sprint 7 Apr 12, 2017
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
Fixed race and added support for all option in docker stats
20db5d8 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
Fixed race and added support for all option in docker stats
a2b5126 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
Fixed race and added support for all option in docker stats
16fda6e 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 14, 2017
Fixed race and added support for all option in docker stats
3a12638 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
matthewavery pushed a commit to matthewavery/vic that referenced this issue May 3, 2017
@matthewavery
Fixed race and added support for all option in docker stats
1ceea5f 
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgtexmex cgtexmex

Labels
area/docker Support for the Docker operations priority/p0
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging a pull request may close this issue.

fixed race condition and memory leak in docker stats cgtexmex/vic
2 participants
@cgtexmex @mhagen-vmware