-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full ci] Updated integration test image to use govc v0.14 #4653
Conversation
FYI - I chatted with @dougm and he said he'd get a new release out later today...so if you want to wait for that then you won't have to revert....thanks and sorry for any confusion. |
Thats cool. Will change the PR once its out |
New release is available: https://github.com/vmware/govmomi/releases/tag/v0.14.0 |
Updated PR to use new version |
@jakedsouza one thing I would ask is that you change the commit message to say what version and where...i.e. "Updated integration test image to use govc v0.14" -- also I'd remove [full ci] from the commit message -- it can be in the PR, but doesn't need to be in the commit message. |
# Should Not Contain ${output} Error: | ||
# ${rc} ${output}= Run And Return Rc And Output docker %{VCH-PARAMS} start -ai ${output} | ||
# Should Be Equal As Integers ${rc} 0 | ||
# Should Not Contain ${output} Error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will never be supported in CI, it needs to be moved to manual/Group17-Manual-TTY pleaes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.drone.local.yml
Outdated
@@ -5,7 +5,7 @@ clone: | |||
|
|||
build: | |||
integration-test: | |||
image: $${TEST_BUILD_IMAGE=gcr.io/eminent-nation-87317/vic-integration-test:1.24} | |||
image: $${TEST_BUILD_IMAGE=gcr.io/eminent-nation-87317/vic-integration-test:1.26} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't jump the version please, any other PRs need to rebase and update when this goes in and the PR using 25 is not going in just yet anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. @maplain This PR takes up tag 1.25, you should move to 1.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
abbd0a8
to
28d164f
Compare
Changes - - Update integration test image to use govc v0.14 - Move test case 1-05 start with attach and interactive to manual test suite
Updated corresponding test documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Updated integration test image to use govc v0.14 Changes - - Update integration test image to use govc v0.14 - Move test case 1-05 start with attach and interactive to manual test suite
* Updated integration test image to use govc v0.14 Changes - - Update integration test image to use govc v0.14 - Move test case 1-05 start with attach and interactive to manual test suite
* Updated integration test image to use govc v0.14 Changes - - Update integration test image to use govc v0.14 - Move test case 1-05 start with attach and interactive to manual test suite
Get latest govc in the integration test image
Required for #4596