Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full ci] Updated integration test image to use govc v0.14 #4653

Merged
merged 2 commits into from
Apr 10, 2017

Conversation

jakedsouza
Copy link
Contributor

Get latest govc in the integration test image

Required for #4596

@cgtexmex
Copy link
Contributor

cgtexmex commented Apr 8, 2017

FYI - I chatted with @dougm and he said he'd get a new release out later today...so if you want to wait for that then you won't have to revert....thanks and sorry for any confusion.

@jakedsouza
Copy link
Contributor Author

FYI - I chatted with @dougm and he said he'd get a new release out later today...so if you want to wait for that then you won't have to revert....thanks and sorry for any confusion.

Thats cool. Will change the PR once its out

@dougm
Copy link
Member

dougm commented Apr 9, 2017

New release is available: https://github.com/vmware/govmomi/releases/tag/v0.14.0

@jakedsouza
Copy link
Contributor Author

New release is available: https://github.com/vmware/govmomi/releases/tag/v0.14.0

Updated PR to use new version

@cgtexmex
Copy link
Contributor

cgtexmex commented Apr 9, 2017

@jakedsouza one thing I would ask is that you change the commit message to say what version and where...i.e. "Updated integration test image to use govc v0.14" -- also I'd remove [full ci] from the commit message -- it can be in the PR, but doesn't need to be in the commit message.

@jakedsouza jakedsouza changed the title [full ci] Bump govc to latest [full ci] Updated integration test image to use govc v0.14 Apr 9, 2017
@jakedsouza jakedsouza changed the title [full ci] Updated integration test image to use govc v0.14 [specific ci=1-05-Docker-Start] Updated integration test image to use govc v0.14 Apr 9, 2017
# Should Not Contain ${output} Error:
# ${rc} ${output}= Run And Return Rc And Output docker %{VCH-PARAMS} start -ai ${output}
# Should Be Equal As Integers ${rc} 0
# Should Not Contain ${output} Error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will never be supported in CI, it needs to be moved to manual/Group17-Manual-TTY pleaes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.drone.local.yml Outdated
@@ -5,7 +5,7 @@ clone:

build:
integration-test:
image: $${TEST_BUILD_IMAGE=gcr.io/eminent-nation-87317/vic-integration-test:1.24}
image: $${TEST_BUILD_IMAGE=gcr.io/eminent-nation-87317/vic-integration-test:1.26}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't jump the version please, any other PRs need to rebase and update when this goes in and the PR using 25 is not going in just yet anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. @maplain This PR takes up tag 1.25, you should move to 1.26

@jakedsouza jakedsouza changed the title [specific ci=1-05-Docker-Start] Updated integration test image to use govc v0.14 [full ci] Updated integration test image to use govc v0.14 Apr 10, 2017
Copy link
Contributor

@mhagen-vmware mhagen-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakedsouza jakedsouza force-pushed the bump-govc branch 2 times, most recently from abbd0a8 to 28d164f Compare April 10, 2017 18:44
Changes -
- Update integration test image to use govc v0.14
- Move test case 1-05 start with attach and interactive to
  manual test suite
@jakedsouza
Copy link
Contributor Author

Updated corresponding test documentation

Copy link
Contributor

@maplain maplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakedsouza jakedsouza merged commit fea2fcd into vmware:master Apr 10, 2017
@jakedsouza jakedsouza deleted the bump-govc branch April 10, 2017 21:50
andrewtchin pushed a commit to andrewtchin/vic that referenced this pull request Apr 12, 2017
* Updated integration test image to use govc v0.14

Changes -
- Update integration test image to use govc v0.14
- Move test case 1-05 start with attach and interactive to
  manual test suite
andrewtchin pushed a commit to andrewtchin/vic that referenced this pull request Jun 13, 2017
* Updated integration test image to use govc v0.14

Changes -
- Update integration test image to use govc v0.14
- Move test case 1-05 start with attach and interactive to
  manual test suite
andrewtchin pushed a commit to andrewtchin/vic that referenced this pull request Jun 14, 2017
* Updated integration test image to use govc v0.14

Changes -
- Update integration test image to use govc v0.14
- Move test case 1-05 start with attach and interactive to
  manual test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants