fixed race and added support for all option in docker stats #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgtexmex
force-pushed
the
del-boca-vista
branch
2 times, most recently
from
25a1c4b
to
8886012
Compare
jzt
approved these changes
Apr 6, 2017
cgtexmex
force-pushed
the
del-boca-vista
branch
2 times, most recently
from
c3b775f
to
713732e
Compare
cgtexmex
changed the title
|
Added the integration tests to this PR -- this is dependent on #4551 |
In some cases a race could be encountered when executing docker stats. The race would result in an orphaned go routine that would be a memory leak. In addition if stats --no-stream -all was requested the persona would hang on any stopped containers. Stats now will consider the container state when processing these requests. Finally, the unit testing coverage was increased to just over 90% and integration tests were created. Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases a race could be encountered when executing docker
stats. The race would result in an orphaned go routine that
would be a memory leak.
In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers. Stats now will consider
the container state when processing these requests.
Finally, the unit testing coverage was increased to just over
90%.
Fixes #4549, #4585, #4421