Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add "black biased" alternative #3

Open
JonathanILevi opened this issue Nov 23, 2018 · 3 comments
Open

Feature request: add "black biased" alternative #3

JonathanILevi opened this issue Nov 23, 2018 · 3 comments

Comments

@JonathanILevi
Copy link
Contributor

Lowering contrast can also be done by making white darker (rather than black lighter). This is easier on the eyes in a dark room and nicer to look at on low quality LCD monitors that only get so dark.

@vn971
Copy link
Owner

vn971 commented Nov 23, 2018

@JonathanILevi if you want, I can make you a *.glsl that makes colors darker, so you can test it out and compare result.
Is that something you'd want?

@vn971 vn971 added the question label Nov 23, 2018
@vn971
Copy link
Owner

vn971 commented Nov 30, 2018

Feel free to reply if you'd want to test the other low-contrast alternative. Closing for now as the current issue doesn't seem like a bug specifically -- rather a question.

@vn971
Copy link
Owner

vn971 commented May 20, 2020

Apparently more than one person wants to have it, so I'll re-open and ask for contributors.

If anybody wants to solve this issue, please edit the script shift_whiteish.glsl to have another constant float black_bias in addition to white_bias. Letting the user only change that value then and observe the result.

Additionally, if one has time, I'd be very happy to accept a merge request that merges the "white-biased" alternatives in only the general one in README. So that you'd have just the basic transformation there out of the box with constants that we like the most. But the user would then be encouraged play with constants, if they want.

Feel free to ask questions on the issue or the proposal.

@vn971 vn971 reopened this May 20, 2020
@vn971 vn971 changed the title Dark Low-Contrast Feature request: add "black biased" alternative May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants