Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement upstream AUR diff #1

Closed
vn971 opened this issue Oct 30, 2018 · 3 comments · Fixed by #43
Closed

implement upstream AUR diff #1

vn971 opened this issue Oct 30, 2018 · 3 comments · Fixed by #43
Labels
feature-request New feature or request

Comments

@vn971
Copy link
Owner

vn971 commented Oct 30, 2018

When installing new versions of an already installed package, the user should be able to review changes made upstream. This includes PKGBUILD and other files.

@vn971 vn971 added the feature-request New feature or request label Oct 30, 2018
@Morganamilo
Copy link
Collaborator

Morganamilo commented Mar 22, 2019

I just pushed this crate https://docs.rs/aur-fetch which may be useful to you. Better error messages is still a todo for me but it should be usable.

One slight problem is that I designed it for batch downloads. As in the helper should resolve all the deps via the RPC ahead of time, then pass all of them to this crate and download them at once. Of course doing it in multiple batches is possible but probably makes it much more annoying to use.

And here's an example binary using this crate: https://asciinema.org/a/MnMRusp1XSRo3ZR5MG7PYqlBh

@vn971
Copy link
Owner Author

vn971 commented Mar 22, 2019

@Morganamilo interesting. I must note that it's a hard problem though: the ways how you can combine diffing, fetching and asking user questions is pretty broad. I'll take a look at your proposal.

@Morganamilo
Copy link
Collaborator

I built this with that in mind. It's a proper library, It never prints anything on it's own. That's up to whoever uses the crate to decide. It does support diffs both as just strings and 'views'.

The view method is pretty much a clone of how aurutils does it if you're familiar with that.

Also this isn't a proposal (otherwise this would be a PR :P) and more hey look at this. But seems as you do want diffs I'd be interested in feedback and if the crate is insufficient in any way for what you want to do.

@vn971 vn971 changed the title upstream AUR diff is not implemented, yet desireable implement upstream AUR diff May 24, 2019
@vn971 vn971 closed this as completed in 0459a8b Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants