Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target_translate in mir-gen-x86_64.c continues even if replacement fails, is this correct? #8

Closed
dibyendumajumdar opened this issue Aug 24, 2019 · 3 comments
Closed

target_translate in mir-gen-x86_64.c continues even if replacement fails, is this correct? #8

dibyendumajumdar opened this issue Aug 24, 2019 · 3 comments

Comments

@dibyendumajumdar
Copy link
Contributor

Not sure if this is an error or not - I got a failure where it seems to have hit this branch.
@vnmakarov
Copy link
Owner

No, it is a bug. The right code selection should always work. I ignored the failure because I wanted to see all failures for one run. I think replacement failure should be a fatal error. I'll fix it when I have time. Unfortunately, next 3-4 2 weeks I can not work on this project. I'll resume my work on it in at the end of September.

@vnmakarov
Copy link
Owner

Btw, I've made the failure in code selection pattern matching a fatal error as it should be.

@dibyendumajumdar
Copy link
Contributor Author

Cool, so I will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dibyendumajumdar @vnmakarov