-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associating a song with multiple parent (original) versions #55
Comments
This could be done by VocaDB/vocadb#558. |
@ycanardeau Perhaps linked to the wrong issue? How is BPM related to multiple song inheritance? |
@dset0x No, it's not wrong. Originally I was thinking having multiple offset-length pairs (which is overly complicated) to support variable BPM.
|
Oh, I think this is too much. I might also not be applicable to many songs. Do you have a use-case for trying to maintain so much information? |
I also don't recommend this suggestion. It sounds too complicated for the main website (feature bloat). If necessary, such information could be on a related website.
I can imagine mashups at least? |
Yes. For example, this song could be associated with 26 parent songs. |
Oh, I understand having multiple parent songs, but I wonder if making a table like the example you gave is generally useful (where you maintain not only the relationship, but also the timing) |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Mostly useful for mashups. Has been requested a few times, for TouhouDB as well.
Would obviously require changing the current association from one-to-many to many-to-many. Could possibly make the performance worse. To mitigate performance penalty we could still use the old original song property to minimize the number of times the collection needs to be accessed.
Still need to evaluate whether it's feasible to implement due to increased complexity and lower performance.
Also need to consider how to implement "filter by parent version" feature. Probably the many-to-many list would need to include the whole parent hierarchy, and maintaining that could be very complicated.
Open issues: if multiple parents are specified, from which should the lyrics and characters be inherited? Could we always use the first parent song (most derived songs only have one parent anyway)?
The text was updated successfully, but these errors were encountered: