Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV/ENH: Switch to using tomlkit #685

Closed
2 tasks
NickleDave opened this issue Jul 23, 2023 · 0 comments
Closed
2 tasks

DEV/ENH: Switch to using tomlkit #685

NickleDave opened this issue Jul 23, 2023 · 0 comments
Assignees
Labels
DEV: development development, not source code: e.g. change dependencies, bump version

Comments

@NickleDave
Copy link
Collaborator

We rely on toml but I don't think it's actively maintained.
It also does not preserve formatting in some cases, e.g. when we add dataset_path at the end of the prep step and re-save the TOML file, it will convert in-line tables into their own separate tables

For example,

[PREDICT]
transform_params = {window_size = 44}

becomes

[PREDICT.transform_params]
window_size = 44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: development development, not source code: e.g. change dependencies, bump version
Projects
None yet
Development

No branches or pull requests

1 participant