Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant vibrations #77

Closed
vodemn opened this issue Jun 4, 2023 · 0 comments · Fixed by #76
Closed

Redundant vibrations #77

vodemn opened this issue Jun 4, 2023 · 0 comments · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@vodemn
Copy link
Owner

vodemn commented Jun 4, 2023

1. Vibration on non-measurement user input

When user changes one of these settings:

  • Language
  • Theme type
  • Primary color
  • Dynamic color

due to this code:

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    _bloc.add(EquipmentProfileChangedEvent(EquipmentProfile.of(context)));
    _bloc.add(StopTypeChangedEvent(context.watch<StopType>()));
    if (!MeteringScreenLayout.featureStatusOf(context, MeteringScreenLayoutFeature.filmPicker)) {
      _bloc.add(const FilmChangedEvent(Film.other()));
    }
  }

response vibration is called.

In order to fix it custom dependency listener can be implemented.

2. Vibration when resulting EV is not changed

Response vibration should be called only when EV and corresponding exposure pairs list are changed.

This can be achieve simply by checking if, for example, new ND values is equal to the current one. If true - nothing happens.

@vodemn vodemn added the bug Something isn't working label Jun 4, 2023
@vodemn vodemn self-assigned this Jun 4, 2023
@vodemn vodemn closed this as completed in #76 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant