Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgeoip: remove dependency on geoip-data #16216

Closed
user318 opened this issue Nov 7, 2019 · 4 comments
Closed

libgeoip: remove dependency on geoip-data #16216

user318 opened this issue Nov 7, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@user318
Copy link

user318 commented Nov 7, 2019

Hello,

Currently libgeoip depends on geoip-data. But as I understand, data is not strictly required for the lib - you can get your own data anywhere. So now, for example, when I try to install nginx on a small system, I get this:

geoip-data install   -                 20171002_2             25MB 
libgeoip   install   -                 1.6.12_1               56KB 
nginx      install   -                 1.16.1_1               347KB 

As you can see geoip-data takes up a huge part of packages install even if I do not need it. I think it is a bad practice and geoip-data should be removed from the dependencies of libgeoip.

@user318
Copy link
Author

user318 commented Nov 9, 2019

@xtraeme Thank you for the tip, it is useful! But isn't this a redundant dependency anyway?

@user318
Copy link
Author

user318 commented Nov 9, 2019

Lib wouldn't stop working. But you need to feed it with some data for it to do something meaningful, of course. It's like what would your image viewer do if there were no images around. geoip-data is a pack of Maxmind's lite databases, as I can see. One may not want to use all of those together, but only one of them. Alternatively one could use paid version of Maxmind's database or any other geoip database provider out there. So, yes, geoip-data may be of use in some cases, but there are also many cases when it is useless or overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@user318 and others