-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically detect XBPS_SUCMD
if not set
#38075
Comments
Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it. |
Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it. |
I'd love to see this implemented! Would something as naive as
work? I don't know what other privilege escalation tools people use, but at least with these three, you can be mostly assured that if someone has |
you need to check if there's a matching rule for sudo/doas too, see what xtools does for some things |
Taking this from
putting it into the header of EDIT: forgot that |
please don't put this anywhere where it will be executed each xbps-src invocation. There are tools that execute xbps-src in a loop on many packages to gather dependencies and each fork is expensive, this function would add a bunch of forks for something that is only required for one sub command. Edit: I guess putting it on line 1003 would be fine. Generally I would prefer less magic or a way to disable this magic and put it where its required i.e. the bulk.sh file instead of adding it to the main script. |
What do you mean by less 'magic', sorry? As in fewer scripts trying to be clever?
Yeah that makes sense. It works fine in |
XBPS_SUCMD
is used for example for build updates withupdate-sys
. Currently it's set tosudo sh -c
in etc/defaults.conf, but we could comment it out and automatically detect common privilege escalation tools - sudo, doas, su (?).The text was updated successfully, but these errors were encountered: