Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: update to 1.19. #38474

Closed
wants to merge 1 commit into from
Closed

go: update to 1.19. #38474

wants to merge 1 commit into from

Conversation

g4s8
Copy link
Contributor

@g4s8 g4s8 commented Aug 5, 2022

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64 - GNU libc)

@classabbyamp
Copy link
Member

I think you need to rebase your branch on the latest master, there are conflicts

@classabbyamp
Copy link
Member

supercedes #38385

@paper42
Copy link
Member

paper42 commented Aug 5, 2022

cc @the-maldridge

@icp1994
Copy link
Contributor

icp1994 commented Aug 5, 2022

golang/go#52919 (comment) should be relevant for the failed i686 build

@paper42 paper42 mentioned this pull request Aug 6, 2022
Closed
@subnut subnut mentioned this pull request Aug 7, 2022
Merged
@subnut
Copy link
Contributor

subnut commented Aug 7, 2022

Failing builds fixed in #38510

@paper42
Copy link
Member

paper42 commented Aug 7, 2022

superseded by #38510

@paper42 paper42 closed this Aug 7, 2022
@g4s8 g4s8 deleted the go-1.19 branch August 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-maldridge the-maldridge Awaiting requested review from the-maldridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@g4s8 @classabbyamp @paper42 @icp1994 @subnut