Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inliner should be implemented in the client #54

Closed
bwl21 opened this issue Nov 25, 2015 · 3 comments
Closed

inliner should be implemented in the client #54

bwl21 opened this issue Nov 25, 2015 · 3 comments
Assignees
Milestone

Comments

@bwl21
Copy link
Contributor

bwl21 commented Nov 25, 2015

I think that the inliner should be implemented in the client side inside mosaico so it is done the same way with no "intelligence" in the backend: the backend should be as dummy as possible and inlining is not a dummy thing (nor a "known transformation" as there is no "one good way to inline").

@bago
Copy link
Member

bago commented Nov 25, 2015

We currently use Styliner in the node.js backend but we cannot use it on the client-size for this issue:

  1. it does not run in the client
  2. it does not support "unknown" properties or multiple properties with the same name in the same property-set
  3. id does not support our "data-inline" attribute.

Maybe we can take some code from Styliner, change the parser to Mensch and then use jQuery to manipulate the resulting code.

@bwl21
Copy link
Contributor Author

bwl21 commented Nov 25, 2015

How bad. This sounds like a lot of work.

@bago
Copy link
Member

bago commented Jun 28, 2016

Just an update to this issue.

We investigated how well known inliners works:
http://mosaico.io/email-client-tricks/email-inliners/

At the end we chose Juice because it was easier to adapt to our need. Juice author was happy to accept and merge our patches to fix the most critical Juice issues and I'm working on the last patch so to make it useable by mosaico.

@bago bago closed this as completed in ecf203f Jun 29, 2016
@bago bago added this to the 0.15 milestone Jun 29, 2016
@bago bago self-assigned this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants