-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] broken flash messages #14
Comments
That is not a bug. It's your responsibility to invalidate snippets. Flash messages are not tied to output in any way. |
ok, I forgot that line in previous example.. $this->flashMessage('test');
$this->redrawControl('flashes');
$this->redirect('this'); after redirect the snippet is not invalidated.. (which is without this extension..) |
The thing about this extension is, that if you make redirect, you make redirect :). Therefore you have to take care of this invalidation in the destination of the redirect (in the newly created app request). |
That's true, but without this extension, this invalidated snippet is discarded immediately by actual redirect in the browser. So with this extension, you have to think about it bit different. |
I see now but haven't realized when I used this extension for the first time. Now it seems obvious but it was not when I was hunting the 'bug' down :) All I'm asking is if any mention in readme of how this extension works & what to be aware of (need of snippet invalidation after 'redirect') would not be helpful for first-time users like I was.. |
Noted. I will try to update readme soon :). |
Thx ;) |
If I use sth. like this in presenter
the flash message will not show up as corresponding snippet (flashes) is not set to be redrawn after forwarding.
The workaround is to check for _fid in
startup
methodbut I lost more than hour to track this down..would be nice to mention this at least somewhere
The text was updated successfully, but these errors were encountered: