Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover Module Should Use UpdatePassword Method #308

Open
ibraheemdev opened this issue Aug 21, 2020 · 1 comment
Open

Recover Module Should Use UpdatePassword Method #308

ibraheemdev opened this issue Aug 21, 2020 · 1 comment

Comments

@ibraheemdev
Copy link
Contributor

ibraheemdev commented Aug 21, 2020 •
edited
Loading

Shouldn't the EndPost() method in the recover module use the UpdatePassword() method, instead of essentially rewriting it? Currently UpdatePassword() is defined but not used internally. Should I make a PR, or is there a reason for this?
@aarondl
Copy link
Member

aarondl commented Aug 26, 2020

Doesn't seem that there's any reason other than EndPost was written before UpdatePassword was. A PR would be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aarondl @ibraheemdev