Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set basename BrowserRouter prop via environment variable #4

Closed
jrigassio-splunk opened this issue Feb 17, 2021 · 0 comments
Closed

Comments

@jrigassio-splunk
Copy link
Contributor

Hello! I am considering using this project, as it nicely combines swagger apis into one portal, but it would integrate better with our existing traffic routing if I was able to specify a prefix URL to the application (i.e. serve the homepage at /foobar and serve apis at /foobar/petshop and /foobar/instagram).

This is actually quite easy with the basename prop to the BrowserRouter component you are already using. I think it'd be convenient if one could specify this as an environment variable to your Dockerfile. Opening a PR for this that I'd love review on when you're able to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants