Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobFlow UT probabilistic failure #2851

Open
wangyang0616 opened this issue May 23, 2023 · 3 comments
Open

JobFlow UT probabilistic failure #2851

wangyang0616 opened this issue May 23, 2023 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@wangyang0616
Copy link
Member

wangyang0616 commented May 23, 2023

What happened:
After add jobflow controller code #2559 is integrated, the code verify of the backbone CI fails to run, which are goimports check and ut

  • The problem of code verify failure for goimports has been fixed, refer to: fix goimport check error #2849
  • ut fails probabilistically, and the error message is as follows:
  --- FAIL: TestGetAllJobStatusFunc (0.00s)
    --- FAIL: TestGetAllJobStatusFunc/GetAllJobStatus_success_case (0.00s)
        jobflow_controller_action_test.go:406: getAllJobStatus() got = &{[] [jobFlowA-B] [] [jobFlowA-A] [] [] [{jobFlowA-B Running 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 0001-01-01 00:00:00 +0000 UTC 0 [{0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC Running}]} {jobFlowA-A Completed 2023-05-23 20:11:14.264146729 +0800 CST m=+0.191925236 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 1 [{0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC Completed}]}] map[jobFlowA-A:{Completed 2023-05-23 20:11:14.264146729 +0800 CST m=+0.191925236 &Duration{Duration:1s,} map[]} jobFlowA-B:{Running 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 nil map[]}] {}}, want &{[] [jobFlowA-B] [] [jobFlowA-A] [] [] [{jobFlowA-A Completed 2023-05-23 20:11:14.264146729 +0800 CST m=+0.191925236 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 1 [{0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC Completed}]} {jobFlowA-B Running 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 0001-01-01 00:00:00 +0000 UTC 0 [{0001-01-01 00:00:00 +0000 UTC 0001-01-01 00:00:00 +0000 UTC Running}]}] map[jobFlowA-A:{Completed 2023-05-23 20:11:14.264146729 +0800 CST m=+0.191925236 &Duration{Duration:1s,} map[]} jobFlowA-B:{Running 2023-05-23 20:11:15.264146729 +0800 CST m=+1.191925236 nil map[]}] {}}
I0523 20:11:14.265981  930956 event.go:285] Event(v1.ObjectReference{Kind:"JobFlow", Namespace:"default", Name:"jobflow", UID:"", APIVersion:"flow.volcano.sh/v1alpha1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'Created' create a job named jobflow-jobtemplate!
FAIL
FAIL	volcano.sh/volcano/pkg/controllers/jobflow	0.264s

What you expected to happen:
ut success
How to reproduce it (as minimally and precisely as possible):
make unit-test

Anything else we need to know?:

Environment:

  • Volcano Version: master
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@wangyang0616 wangyang0616 added the kind/bug Categorizes issue or PR as related to a bug. label May 23, 2023
@wangyang0616
Copy link
Member Author

In order to ensure that the integration of other PRs in the trunk is not affected, the case involving this issue is temporarily skipped, and the follow-up will be tracked and repaired through this issue.

For details, see:

func TestGetAllJobStatusFunc(t *testing.T) {
// TODO(wangyang0616): First make sure that ut can run, and then fix the failed ut later.
// See issue for details: https://github.com/volcano-sh/volcano/issues/2851
t.Skip("Test cases are not as expected, fixed later. see issue: #2851")

@lowang-bh
Copy link
Member

Becaulse of that there is no jobflow crd at all. See issue #2867

@stale
Copy link

stale bot commented Sep 17, 2023

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants