use one helm command to install resource #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
|
/assign @wangyang0616 @hwdef @william-wang |
|
helm install crds installed. |
hwdef
reviewed
Jul 22, 2023
hwdef
reviewed
Jul 22, 2023
hwdef
reviewed
Jul 22, 2023
Signed-off-by: lowang-bh <lhui_wang@163.com>
|
/priority important-soon |
volcano-sh-bot
added
the
priority/important-soon
|
/assign @Thor-wl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
I think this pr can cherry-pick to the release-1.8 branch. @lowang-bh |
Have opened an PR. Plese help to review #3017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use one command to install helm resource with sub charts, there are mainly two benefit:
helm install volcano installer/helm/chart/volcano --namespace volcano-system --create-namespace), such as kubeflowIn the future, if there are more subcharts, just
installer/helm/chart/volcano/charts/installer/helm/chart/volcano/Chart.yamlRelative PRs: #2882, #2936