Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deploy yamls about jobflows by make generate-yaml & make update-development-yaml #2882

Closed
wants to merge 2 commits into from

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 30, 2023

fix #2867 #2883 jobflow related issue

part-2: add jobflow's crd files in deploy yamls( generated by make generate-yaml & make update-development-yaml)

Please merge #2874 first.

Notes: it will fail to upgrade helm release via helm upgrade --install volcano due to yaml is too long

UPGRADE FAILED: create: failed to create: Secret "sh.helm.release.v1.volcano.v3" is invalid: data: Too long: must have at most 1048576 bytes

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 30, 2023
…e-development-yaml

Signed-off-by: lowang_bh <lhui_wang@163.com>
@william-wang
Copy link
Member

@lowang-bh please help to fix the ci failure.

@lowang-bh
Copy link
Member Author

@lowang-bh please help to fix the ci failure.

Yes, I am thinking out a solution about helm install error data: Too long: must have at most 1048576 bytes. It need to split up the chart.

@william-wang
Copy link
Member

@lowang-bh please help to fix the ci failure.

Yes, I am thinking out a solution about helm install error data: Too long: must have at most 1048576 bytes. It need to split up the chart.

@lowang-bh Are you working on spliting up the chart or need other contributor to work with it?

@lowang-bh
Copy link
Member Author

@lowang-bh Are you working on spliting up the chart or need other contributor to work with it?

Yes, but it still can not work well. Welcome help from other contributors.

@wangyang0616
Copy link
Member

I submitted a pr #2936, the crd related to jobflow in the current pr, to solve the problem that the helm installation exceeds the upper limit of 1MB, please help to review @lowang-bh

@william-wang
Copy link
Member

@lowang-bh #2936 has resolved the helm issue. Please move forward to update this pr. Thanks.

@lowang-bh lowang-bh closed this Jul 13, 2023
Signed-off-by: lowang-bh <lhui_wang@163.com>
@lowang-bh lowang-bh reopened this Jul 20, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service accout has no permit about flow.volcano.sh in jobflow
4 participants