Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick for release-1.8] use one command of helm install to do smooth upgrade #3017

Merged

Conversation

lowang-bh
Copy link
Member

cherry-pick for release-1.8: use one helm command to install resource #2985

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2023
@lowang-bh
Copy link
Member Author

/assign @wangyang0616 @william-wang @Thor-wl

Signed-off-by: lowang-bh <lhui_wang@163.com>
@wangyang0616
Copy link
Member

I think this pr is reasonable and needs to be released in v1.8.

After the current pr is integrated, the CI error of release charts can be repaired. When tags are generated through release-1.8, the helm-charts warehouse release package can be automatically triggered.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@volcano-sh-bot volcano-sh-bot merged commit 19e2c4f into volcano-sh:release-1.8 Aug 2, 2023
8 checks passed
@lowang-bh lowang-bh deleted the cherry_pick_helm_install branch July 27, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants