Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of minor miscellaneous cleanups #37

Closed
wants to merge 8 commits into from

Conversation

mebigfatguy
Copy link
Contributor

add hashCode's
move fields to locals to help out the gc
fix Integer comparisons
make sure streams get closed
remove dead code
etc.

@afeinberg
Copy link
Contributor

Looks good, good catch on some of those (I had another branch where I added hashCode to some of those but haven't committed it yet).

Only one request: Can you remove the "remove dead code" commit? There's a separate issue there (handling correct zone semantics for getAll()) that I'll deal with in a separate commit.

@mebigfatguy
Copy link
Contributor Author

Can you remove the "remove dead code" commit?

sure, but, how do i do that? :)

@afeinberg
Copy link
Contributor

I can do that then, I'll just cherry pick all commits but that.

  • Alex

@rsumbaly
Copy link
Contributor

Good catch...@alex - we should definitely work on that findbugs branch of mine :) Also whenever you cherry pick it can you please also merge it into our 1046 branch?

@afeinberg
Copy link
Contributor

Merged this in.

Roshan and I will take a look to see what the right thing to do is regarding the "dead code" in PerformParallelGetAllRequests is.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants