A bunch of minor miscellaneous cleanups #37

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
3 participants
@mebigfatguy
Contributor

mebigfatguy commented Dec 26, 2010

add hashCode's
move fields to locals to help out the gc
fix Integer comparisons
make sure streams get closed
remove dead code
etc.

@afeinberg

This comment has been minimized.

Show comment Hide comment
@afeinberg

afeinberg Dec 27, 2010

Contributor

Looks good, good catch on some of those (I had another branch where I added hashCode to some of those but haven't committed it yet).

Only one request: Can you remove the "remove dead code" commit? There's a separate issue there (handling correct zone semantics for getAll()) that I'll deal with in a separate commit.

Contributor

afeinberg commented Dec 27, 2010

Looks good, good catch on some of those (I had another branch where I added hashCode to some of those but haven't committed it yet).

Only one request: Can you remove the "remove dead code" commit? There's a separate issue there (handling correct zone semantics for getAll()) that I'll deal with in a separate commit.

@mebigfatguy

This comment has been minimized.

Show comment Hide comment
@mebigfatguy

mebigfatguy Dec 27, 2010

Contributor

Can you remove the "remove dead code" commit?

sure, but, how do i do that? :)

Contributor

mebigfatguy commented Dec 27, 2010

Can you remove the "remove dead code" commit?

sure, but, how do i do that? :)

@afeinberg

This comment has been minimized.

Show comment Hide comment
@afeinberg

afeinberg Dec 27, 2010

Contributor

I can do that then, I'll just cherry pick all commits but that.

  • Alex
Contributor

afeinberg commented Dec 27, 2010

I can do that then, I'll just cherry pick all commits but that.

  • Alex
@rsumbaly

This comment has been minimized.

Show comment Hide comment
@rsumbaly

rsumbaly Dec 27, 2010

Contributor

Good catch...@alex - we should definitely work on that findbugs branch of mine :) Also whenever you cherry pick it can you please also merge it into our 1046 branch?

Contributor

rsumbaly commented Dec 27, 2010

Good catch...@alex - we should definitely work on that findbugs branch of mine :) Also whenever you cherry pick it can you please also merge it into our 1046 branch?

@afeinberg

This comment has been minimized.

Show comment Hide comment
@afeinberg

afeinberg Dec 27, 2010

Contributor

Merged this in.

Roshan and I will take a look to see what the right thing to do is regarding the "dead code" in PerformParallelGetAllRequests is.

Contributor

afeinberg commented Dec 27, 2010

Merged this in.

Roshan and I will take a look to see what the right thing to do is regarding the "dead code" in PerformParallelGetAllRequests is.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment