Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade code option to the initialize and print subcommands #116

Closed
volks73 opened this issue Nov 3, 2020 · 1 comment
Closed

Add upgrade code option to the initialize and print subcommands #116

volks73 opened this issue Nov 3, 2020 · 1 comment
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented Nov 3, 2020

An -U,--upgrade-code option that takes a string should be added to the cargo wix init and cargo wix print subcommands. This would override the automatically generated GUID for the product's upgrade code with an existing GUID generated via some other mechanism or tool.

This would be useful if porting an installer build from another tool to use the cargo wix subcommand. It would also be useful to create "ephemeral" installers in CI workflows (See #88).

@volks73 volks73 self-assigned this Nov 3, 2020
@volks73
Copy link
Owner Author

volks73 commented Nov 3, 2020

Implemented as of 39fe04e.

I decided to name the option "upgrade-guid" instead of "upgrade-code" to be eventually consistent with the "path-guid" option. I am not sure if the -U short name will stay very long. It was available, but the -P that would be used for the "path-guid" option is already used and I am not sure if this option will be common enough to warrant a short name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant