Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sensor interpreter and add resolution #165

Closed

Conversation

andig
Copy link
Contributor

@andig andig commented Jun 22, 2014

Fixes #158 and adds resolution parameter to SensorInterpreter

NEEDS TESTING

@andig
Copy link
Contributor Author

andig commented Jun 24, 2014

ATTENTION Don't commit!

SensorInterpreter resolution fix confirmed by tester, but severe performance impact.

@andig
Copy link
Contributor Author

andig commented Jun 28, 2014

I've left the weighed average SQL code in to demonstrate what can/should be done unless we change the DB schema. It is disabled though. Using tuple packaging (tuples=xy) does calculate correct results now, grouped queries and aggregation won't, just as before.
Behaviour confimed by tests.

@andig
Copy link
Contributor Author

andig commented Jun 30, 2014

Wfm bei Nils: Also bei der Performance merke ich jetzt keinen wirklichen Unterschied mehr zu vorher. Die Einheiten funktionierten ja eh schon.
Falsche Daten habe ich nicht gesehen (die hatte ich aber auch vorher nicht bemerkt), Aggregation nutze ich noch nicht.

Ich erstelle nochmal sauberen Commit, dann rein damit.

@andig
Copy link
Contributor Author

andig commented Jul 1, 2014

Superseeded by #174

@andig andig closed this Jul 1, 2014
@andig andig deleted the fix-sensor-interpreter-add-resolution branch August 19, 2014 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power sensor consumption wrong when tuples=1
1 participant