amdify/npmrel fail on "this" as exports idiom

[asutherland]

This file:
https://github.com/andris9/mailparser/blob/master/lib/datetime.js

whose content is basically:

this.strtotime = function(str, now) {
}

Does not amdify properly. When I use npmrel, the wrapper is:

//Wrapped in an outer function to preserve global this
(function (root) { define([undefined], function (undefined) { (function () {
....
}.call(root));

undefined
}); }(this));

When I manually use amdify, it looks similar, but the undefineds aren't there. FWIW, the module does work "properly" in node.

[asutherland]

er, and when RequireJS goes and requires the file, it gets undefined out. I double-checked by going to require.s.contexts._.defined["mailparser/datetime"] and its value is undefined there too.

[jrburke]

This should be fetched in master:
https://raw.github.com/volojs/volo/master/dist/volo

so the converted file would now look like:

define(function (require, exports, module) {

  this.strtotime = function(str, now) {
  }

});

which should also work in requirejs. The "this" binding should be the exports object for the define factory call with the above conversion syntax.

[asutherland]

Woo, thanks! I had a look at the source but the specific problem did not jump out at me. Glad to see it was obvious to you!