Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-1041 Email notification checkbox on person detail form #599

Merged
merged 3 commits into from
Jan 25, 2020

Conversation

tyrannosaurusjames
Copy link
Contributor

I do solemnly swear that I have:

  • Run npm test and all the tests pass.
  • Run npm run lint and there are no warnings.
  • Not decreased the overall test coverage?
  • Included the Jira ID and description in the PR title

Proposed Changes? 🤔

  1. Add email notification checkbox to person detail form

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #599 into master will increase coverage by 0.06%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   85.22%   85.28%   +0.06%     
==========================================
  Files         252      253       +1     
  Lines        3628     3643      +15     
==========================================
+ Hits         3092     3107      +15     
  Misses        536      536
Impacted Files Coverage Δ
components/Op/OpBanner.js 100% <ø> (ø) ⬆️
server/api/story/story.controller.js 40% <ø> (ø) ⬆️
components/Op/OpCloseOpportunity.js 100% <ø> (ø) ⬆️
components/Op/OpCard.js 100% <ø> (ø) ⬆️
pages/org/orgdetailpage.js 100% <100%> (ø) ⬆️
components/VTheme/VTheme.js 100% <100%> (ø) ⬆️
pages/act/actdetailpage.js 95.52% <100%> (+0.2%) ⬆️
components/Op/OpTabs.js 100% <100%> (ø) ⬆️
components/Story/AddStory.js 100% <100%> (ø)
components/Op/OpAboutPanel.js 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb5719...3512b7d. Read the comment docs.

@avowkind avowkind merged commit 7bcdb3e into master Jan 25, 2020
@avowkind avowkind deleted the feat/VP-1041/email-notification-checkbox branch January 25, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants