New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme example does not compile in TS #866

Closed

capaj opened this issue Sep 15, 2023 · 2 comments

Assignees

Labels

types

capaj commented Sep 15, 2023 •

edited

Loading

Expected Behavior

readme example in
https://github.com/Vonage/vonage-node-sdk/blob/3.x/packages/server-client/README.md
should compile in TS

Current Behavior

Possible Solution

not marking the Client class as abstract

Steps to Reproduce (for bugs)

try to compile example code with TS

Context

Your Environment

SDK Version:
"@vonage/server-client": "^1.8.2",
Node Version: (e.g. Node 10.18): all of them
Operating System and version: any

manchuck self-assigned this

manchuck added the types label

Contributor

manchuck commented Dec 15, 2023

@capaj #872 is a complete rework of our documentation. When that is released in early Jan, this issue should be resolved

Contributor

manchuck commented Jan 11, 2024

This should be resolved with version 3.12.0

manchuck closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment