Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackHandler listener not removed #4

Closed
londonoliver opened this issue Jun 22, 2018 · 1 comment · Fixed by #5
Closed

BackHandler listener not removed #4

londonoliver opened this issue Jun 22, 2018 · 1 comment · Fixed by #5

Comments

@londonoliver
Copy link
Contributor

When calling navigation.popToTop() in a StackNavigator, willUnmount is called before willBlur, and the BackHandler listener is not removed.
@londonoliver londonoliver mentioned this issue Jun 22, 2018
Merged
@vonovak
Copy link
Owner

vonovak commented Jun 22, 2018

hi @londonoliver, thanks for reporting. For the record, the problem is that willUnmount is called first and removes the willBlur subscription and the BackHandler.removeEventListener in willBlur is therefore not called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove BackHandler listener on component unmount londonoliver/react-navigation-backhandler
2 participants
@vonovak @londonoliver