Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to invert completion highlighting #55

Closed
andrei-a-papou opened this issue Feb 23, 2024 · 2 comments
Closed

Patch to invert completion highlighting #55

andrei-a-papou opened this issue Feb 23, 2024 · 2 comments
Milestone

Comments

@andrei-a-papou
Copy link

andrei-a-papou commented Feb 23, 2024

I'm using this patch to invert highlighting in the completion dropdown. Without it, at least in a terminal with a dark background, the highlighting in the completion dropdown is light text on dark background, whereas everywhere else in the app it's the reverse (dark text, light background). Especially for completions in the search bar where you also have a highlighted item in the task list nearby, this never fails to confuse me 😄 Hence the patch.

98-reverse-completion-colors.diff.gz

Ideally, maybe the completion dropdown could simply mimic "Select project" and "Select context" dialogs, i. e. have the same borders and colors, only with no label/title? But I bet there's probably a good reason the completion dropdown is different?

@vonshednob
Copy link
Owner

This has confused me a lot, too. But apparently never enough to change it 😅

@vonshednob vonshednob added this to the Version 3.16 milestone Feb 23, 2024
@vonshednob
Copy link
Owner

Pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants