Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome: 'Range.detach' is now a no-op, as per DOM #54

Closed
corbinu opened this issue Jun 11, 2014 · 6 comments
Closed

Chrome: 'Range.detach' is now a no-op, as per DOM #54

corbinu opened this issue Jun 11, 2014 · 6 comments

Comments

@corbinu
Copy link

corbinu commented Jun 11, 2014

In Chrome I get an warning which reads:
'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach).

It appears to be in wysihtml5x-toolbar.js at line 2989

@dhoulb
Copy link

dhoulb commented Jul 31, 2014

I'm getting the same thing. Happens on DOM load (before I've instantiated a WYSIWYG area). I'm guessing it's part of some browser compatibility testing that WYSIHTML5 or Rangy does early on.

I'm also getting a The given range and the current selection belong to two different document fragments. error, which I assume is related.

@timdown
Copy link

timdown commented Aug 1, 2014

Rangy does do feature tests during initialization which cause recent Chrome to warn both "'Range.detach' is now a no-op, as per DOM" and "Discontiguous selection is not supported.". The latest version of Rangy on GitHub has workarounds for both.

@adantart
Copy link

adantart commented Aug 5, 2014

just a question, do we have to upgrade Rangy by ourselves or are you going to upgrade the lib here ?

@timdown
Copy link

timdown commented Aug 5, 2014

Is that directed at me, @adantart? If so then I'm happy to create a pull request with the latest version of Rangy but I'd have thought it would be just as simple to download the latest release from https://github.com/timdown/rangy/releases and do it yourselves.

@adantart
Copy link

adantart commented Aug 6, 2014

Yes, I know it's that simple, but just wanted to know if I have to, or better to wait the main project (yours) to do it, and then I upgrade yours ;-)
It's not about "who" is doing this, but having a clean repository dependencies. I prefer to upgrade your package when it's upgraded, if not, I will have conflicts when I upgrade yours after changing a library inside it.

@kasoban
Copy link

kasoban commented Aug 6, 2014

@adantart I think there is some misunderstanding here, @timdown is not the maintainer of Edicy/wysihtml5 but of Rangy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants