Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor correction] package.xml with repeated dependencies #104

Closed
TSC21 opened this issue Aug 11, 2014 · 3 comments
Closed

[minor correction] package.xml with repeated dependencies #104

TSC21 opened this issue Aug 11, 2014 · 3 comments
Labels

Comments

@TSC21
Copy link
Member

TSC21 commented Aug 11, 2014

In https://github.com/vooon/mavros/blob/master/mavros/package.xml.
Removing ambigual build_depend, it will stay like this:

  <buildtool_depend>catkin</buildtool_depend>
  <build_depend>boost</build_depend>
  <build_depend>diagnostic_msgs</build_depend>
  <build_depend>diagnostic_updater</build_depend>
  <build_depend>message_generation</build_depend>
  <build_depend>pluginlib</build_depend>
  <build_depend>roscpp</build_depend>
  <build_depend>rospy</build_depend>
  <build_depend>geometry_msgs</build_depend>
  <build_depend>sensor_msgs</build_depend>
  <build_depend>std_msgs</build_depend>
  <build_depend>tf</build_depend>
  <build_depend>mavlink</build_depend>
  <build_depend>angles</build_depend>
  <test_depend>gtest</test_depend>

Can you check?

@TSC21
Copy link
Member Author

TSC21 commented Aug 11, 2014

By the way, what's the problem with Travis CI build, which cannot compile?

@vooon
Copy link
Member

vooon commented Aug 11, 2014

It use old mavlink deb.

Now wiki.ros.org recommend package.xml version 2, but tools don't generate it now (but support).
It can reduce depend tags.

@TSC21
Copy link
Member Author

TSC21 commented Aug 11, 2014

Oh ok. It doesn't really matter is just a thing of organisation.

@vooon vooon added the question label Aug 11, 2014
@vooon vooon closed this as completed in 81286eb Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants