Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mavlink msgs #94

Closed
2 of 5 tasks
TSC21 opened this issue Aug 8, 2014 · 29 comments
Closed
2 of 5 tasks

Update Mavlink msgs #94

TSC21 opened this issue Aug 8, 2014 · 29 comments

Comments

@TSC21
Copy link
Member

TSC21 commented Aug 8, 2014

mavlink/c_library_v1@23a8961. New msg definitions!

Some updates:

Mandatory:

Optional:

Without the first ones is not possible to test setpoints. Does the ros-*-mavlink will be getting the new message definitions?

@vooon
Copy link
Member

vooon commented Aug 8, 2014

But no new required for 0.7 messages. Will update after releasing 0.7.

@vooon
Copy link
Member

vooon commented Aug 8, 2014

So it required for setpoint plugins? Ok then i release it now.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

So it required for setpoint plugins? Ok then i release it now.

Yes. The offboard2_externalsetpointmessages PX4 Firmware branch will get the new messages soon, so we must be able to send this msgs when it's out.

@vooon
Copy link
Member

vooon commented Aug 8, 2014

But releasing new version will break our builds until deb sync.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

Can you get it in a dev branch? Then we try new mavlink by downloading it to a local usr folder and chnage it's path on CMakeList.txt. Can you add the steps to do this in the dev branch Readme.md you create?

How much time does it usually take to deb sync?

@vooon
Copy link
Member

vooon commented Aug 8, 2014

I can't predict when it updates (wiki says 1-2 weeks). And, no master is development branch. But you can manually install new debs from shadow repo.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

But you can manually install new debs from shadow repo.

How to then? We will need this working so better start now.

@vooon
Copy link
Member

vooon commented Aug 8, 2014

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

Stable repo: http://packages.ros.org/ros/ubuntu/pool/main/r/ros-hydro-mavlink/
Unstable: http://packages.ros.org/ros-shadow-fixed/ubuntu/pool/main/r/ros-hydro-mavlink/

So what's the procedure now to install it? Can we use wstool? What does change in the install tutorial?

@vooon
Copy link
Member

vooon commented Aug 8, 2014

Source install have no change. For few days/weeks need manually download and install deb (for x86) from shadow repository.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

@vooon what's the difference between the two above link repos? They seem both to have the previous sub version of mavlink.

@vooon
Copy link
Member

vooon commented Aug 8, 2014

First is stable, it sometimes synchronize with "shadow" repo, where jenkins store build result.
Shadow repo will update soon.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

Ok. So after the shadow update we download the file and do sudo dpkg -i <ros-hydro-mavlink_...>, right?

@vooon
Copy link
Member

vooon commented Aug 8, 2014

Right. Or build it from source (dh binary notes) if it not arrives soon.

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

Ok. In the meantime I think I have already checked what should be and what could be optionally modified or added to the code. But probably it's better you check out the new definitions by yourself and see what must and could be modified.

@vooon
Copy link
Member

vooon commented Aug 8, 2014

Just update (build deb from source), and build is broken, but in unexpected place:

/opt/ros/indigo/include/mavlink/v1.0/pixhawk/../checksum.h:2:10: error: expected unqualified-id before string constant
 extern "C" {

@TSC21
Copy link
Member Author

TSC21 commented Aug 8, 2014

Well if it is a build problem or we check it ourselves or we inform about it in mavlink/c_library_v1@23a8961. What's the next step?

@vooon
Copy link
Member

vooon commented Aug 8, 2014

First i must find the source.

@vooon
Copy link
Member

vooon commented Aug 9, 2014

Found two issues: mavlink/mavlink#232 and mavlink/mavlink#233 .

While 232 is trivial (and already fixed), 233 require some time.

@vooon
Copy link
Member

vooon commented Aug 9, 2014

All closed, and i release hotfix packages for ros.

@vooon
Copy link
Member

vooon commented Aug 9, 2014

Done today my first fligth... maximum fligth time ~30 sec.

@TSC21
Copy link
Member Author

TSC21 commented Aug 10, 2014

All closed, and i release hotfix packages for ros.

Checked! 👍

What's the next step then?

Done today my first fligth... maximum fligth time ~30 sec.

With your Bixler? Doesn't seem bad at all for a first fligh ;)

@vooon vooon mentioned this issue Aug 11, 2014
5 tasks
@vooon vooon added this to the Version 0.7.0 milestone Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
vooon added a commit that referenced this issue Aug 11, 2014
@vooon vooon modified the milestones: Version 0.7.0, Version 0.8.0 Aug 11, 2014
@vooon
Copy link
Member

vooon commented Aug 11, 2014

Required changes for 0.7 done. Handling additional messages goes to 0.8.

@TSC21
Copy link
Member Author

TSC21 commented Aug 11, 2014

Checked 👍 what's next then?

@vooon
Copy link
Member

vooon commented Aug 11, 2014

#100. Woohoo first hundred issues.

@TSC21
Copy link
Member Author

TSC21 commented Aug 12, 2014

@vooon I want to update to the new mavlink sub-ver. How can I do that? I clone from https://github.com/mavlink/mavlink and then how do I add the content to the mavlink ROS folder?
It's a noob question I know but I want to set this up quickly. Thanks!

@TSC21
Copy link
Member Author

TSC21 commented Aug 12, 2014

Oh wait: shadow repo seems to be updated! Gonna try it then!

Update: Done! mavros build perfectly ;)

@TSC21
Copy link
Member Author

TSC21 commented Aug 12, 2014

Another good update: mavros with new mavlink sub-rev4 builds perfectly on the Odroid too! 👍

So, ARM platform also tested and approved!

@vooon vooon removed this from the Version 0.8.0 milestone Sep 11, 2014
@vooon
Copy link
Member

vooon commented Mar 1, 2015

I think we may close this issue. Maybe better use new message for complete IMU+ATTITUDE data in one piece.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants