Make mul_add inline #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experience shows that rustc [can fail to inline it in some circumstances](https://internals.rust-lang.org/t/caller-side-inline-directives/19078/7?u=hadrieng), which is Very Bad.
|
And I've seen the other effect, something getting inlined and being slower too… but OK. Do you want me to make a release with this? |
|
Indeed, excessive inlining can cause problems and the I do not need a release immediately as this only degrades the performance of multiple codegen units, and I'm currently stuck with a single codegen unit for other reasons... Just preparing for a bright future when I will someday be able to remove that |
|
OK, poke me when you feel like a release would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experience shows that rustc can fail to inline it in some circumstances, which is Very Bad.