Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential CWE-352 vulnerability in OdataToEntity.AspNetCore #45

Open
dshalkhakov opened this issue May 20, 2020 · 1 comment
Open

Potential CWE-352 vulnerability in OdataToEntity.AspNetCore #45

dshalkhakov opened this issue May 20, 2020 · 1 comment
Labels
help wanted

Comments

@dshalkhakov
Copy link

Hello,

So I've run a SAST scan with a certain tool against OdataToEntity source code and it uncovered the following issue: CWE-352 in OdataToEntity.AspNetCore.OeBatchController BatchCore() and Batch() methods.

I think it should be fixed on the application level, not by the library, by introducing CSRF token middleware or authorization filter. The OeBatchController can also be made abstract so that the responsibility for CSRF prevention be moved to the calling application.

Thoughts?

Cheers,
Dmitry
@voronov-maxim
Copy link
Owner

voronov-maxim commented May 20, 2020 •
edited

ValidateAntiForgeryTokenAttribute can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshalkhakov @voronov-maxim