Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide about PS < 5.0 support #64

Open
vors opened this issue Sep 20, 2018 · 2 comments
Open

Decide about PS < 5.0 support #64

vors opened this issue Sep 20, 2018 · 2 comments

Comments

@vors
Copy link
Owner

vors commented Sep 20, 2018

We should either declare

# Minimum version of the Windows PowerShell engine required by this module
PowerShellVersion = '5.0'

or avoid using ::new() syntax

https://github.com/vors/ZLocation/pull/62/files#r219012334

Both options seems pretty easy to implement, I have a sligh preference toward using the 3.0+ support, but as @cspotcode pointed out the tool is only for interactive use, so for most people it's probably fine to have 5.0+ only.

@cspotcode
Copy link
Contributor

cspotcode commented Sep 25, 2018 via email

@pauby
Copy link

pauby commented Dec 3, 2018

@cspotcode pointed out the tool is only for interactive use, so for most people it's probably fine to have 5.0+ only.

This for me is the key. I'd give a thumbs up to PS 5 as a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants