-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide about PS < 5.0 support #64
Comments
This was referenced Sep 20, 2018
I think there's also a performance difference between the two, but that
probably doesn't matter for us since object creation isn't happening in any
hot code paths.
…On Thu, Sep 20, 2018, 12:48 AM Sergei Vorobev ***@***.***> wrote:
We should either declare
# Minimum version of the Windows PowerShell engine required by this module
PowerShellVersion = '5.0'
or avoid using ::new() syntax
https://github.com/vors/ZLocation/pull/62/files#r219012334
Both options seems pretty easy to implement, I have a sligh preference
toward using the 3.0+ support, but as @cspotcode
<https://github.com/cspotcode> pointed out the tool is only for
interactive use, so for most people it's probably fine to have 5.0+ only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW-uKy8aZxo9_pRq5SOaH-l0j9LL_9kks5ucx4ggaJpZM4WxYJl>
.
|
This for me is the key. I'd give a thumbs up to PS 5 as a minimum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should either declare
or avoid using
::new()
syntaxhttps://github.com/vors/ZLocation/pull/62/files#r219012334
Both options seems pretty easy to implement, I have a sligh preference toward using the 3.0+ support, but as @cspotcode pointed out the tool is only for interactive use, so for most people it's probably fine to have 5.0+ only.
The text was updated successfully, but these errors were encountered: