🐛 the second weighted path is picked

[zhaocai]

🐛 Somehow, the second weighted path is picked.

> z -l posh

Weight Path
------ ----
   107 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\oh-my-posh
    65 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\posh-git
    12 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\git-status-cache-posh-client
     6 C:\ProgramData\chocolatey\lib\git-status-cache-posh-client
     6 C:\ProgramData\chocolatey\lib\git-status-cache-posh-client\tools\git-status-cache-posh-client-1.0.0

> z posh ; pwd

Path
----
C:\Users\Zhao\Documents\WindowsPowerShell\Modules\posh-git

👍 However, sometimes the first weighted path is chosen as expected.

> z -l app

Weight Path
------ ----
    16 C:\tools\scoop\apps
    12 C:\Users\Zhao\AppData
     7 C:\Users\Zhao\AppData\Local\atom\app-1.9.9
     5 C:\Users\Zhao\Dropbox\Apps

 z app ; pwd

Path
----
C:\tools\scoop\apps

💡 Any idea?

[vors]

Hmm, I think there could be some logic about preferring the (apparently case-sensitive) prefixes... cannot quickly find it.

[Snaptags]

I have similar cases and my guess is that matches at the beginning of the folder name are being preferred, regardless of the entry's weight:
107 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\oh-my-posh
65 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\posh-git

That is of course a valid metric, BUT weight should overrule the "beginning of name" rule.

[theaquamarine]

The issue is at

ZLocation/ZLocation/ZLocation.Search.psm1

Lines 18 to 30 in 29cb9e6

	# we should prefer paths that start with the query over paths with bigger weight
	# that don't.
	# i.e. if we have
	# /foo = 1.0
	# /afoo = 2.0
	# and query is "fo", we should prefer /foo
	$res = $hash.GetEnumerator() | % {
	New-Object -TypeName PSCustomObject -Property @{
	Name=$_.Name
	Value=$_.Value
	Starts=[int](Start-WithPrefix -Path $_.Name -lowerPrefix $lowerPrefix)
	}
	} | Sort-Object -Property Starts, Value -Descending

, the results are sorted by whether or not they start with the prefix, then by their value. Changing

ZLocation/ZLocation/ZLocation.Search.psm1

Line 30 in 29cb9e6

} | Sort-Object -Property Starts, Value -Descending

to Sort-Object -Property Value, Starts -Descending should resolve this, as results will then be sorted by value first, only using the prefix if two have the same value.

[vors]

Oh yeah, I remember now. #26 where it started. I don't know what's really the right answer here - should the tool try to be smarter or should it try to be dumber but more predictable.

[eamodio]

I have been seeing the same issue and its been driving me nuts 😄

[deviousasti]

Any workarounds for this?