fix ctp_dipro

[GoogleCodeExporter]

Needs a lot of clean up, example:
$ ctp_dipro 123 456
/home/christoph/votca/bin/ctp_dipro: line 189: do_external: command not found

- rename it to *.in for getting version in there
- make use of csg_call functions as ctp depends on csg anyway
- rm do_external calls or source function_common

Comments?

Original issue reported on code.google.com by christop...@gmail.com on 5 Nov 2011 at 3:30

[GoogleCodeExporter]

Original comment by christop...@gmail.com on 5 Nov 2011 at 3:36

• Added labels: Milestone-Release1.3
• Removed labels: Milestone-Release1.0

[GoogleCodeExporter]

This code should run on a supercomputer architecture, since it dose analysis of 
large dump files. As few dependencies as possible = no csg_call. 

Original comment by andrienko@googlemail.com on 5 Nov 2011 at 9:29

[GoogleCodeExporter]

I just want to avoid duplication on shell functions (currently die, 
do_external, enable_logging, ..) Some functions could also be removed.

As csg_call only depends on bash, as ctp_dipro does, so it adds no extra 
dependencies.

Original comment by christop...@gmail.com on 5 Nov 2011 at 4:23

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

As I see it, we can strip everything from ctp_dipro, except for --monomer, 
--dimer, --check, and --write. Everything else is just a leftover from copying 
some csg base script and can go to the land of eternal facepalm. 

Original comment by bjoern.b...@gmail.com on 5 Nov 2011 at 4:34

[GoogleCodeExporter]

I don't see any big dependency problem here since csg_* is also used on 
supercomputers. Furthermore, one can disable almost all external dependencies 
in csg compilation (expect for expat). On the other side i don't see any 
problems in duplicate (little) bits of code.

To conclude, if usability and error handling can be improved by using csg_* I 
vote for that, if not I don't care.

Original comment by victor.r...@gmail.com on 5 Nov 2011 at 11:25

[GoogleCodeExporter]

I partly reworked it, feel free to improve it even more, but remember to edit 
ctp_dipro.in from now on.

Original comment by christop...@gmail.com on 6 Nov 2011 at 12:30

• Changed state: Started

[GoogleCodeExporter]

Writing to the state file has to be checked
 - frame number
 - field names (hole/electron)
 - provide access from an application?

Original comment by andrienko@googlemail.com on 30 Mar 2012 at 8:01

[GoogleCodeExporter]

Original comment by andrienko@googlemail.com on 30 Mar 2012 at 8:02

[GoogleCodeExporter]

Original comment by andrienko@googlemail.com on 26 May 2013 at 5:08

• Changed state: WontFix