feat(scan): CLI for PDI scanner #4018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventualbuddha
force-pushed
the
pdi-rs
branch
5 times, most recently
from
4a14dc4
to
2fe303b
Compare
eventualbuddha
force-pushed
the
pdi-rs
branch
from
2fe303b
to
547d6c2
Compare
|
@eventualbuddha I've been slacking here. Is a review still useful? |
|
Reviewing the TUI from a user perspective would be potentially useful, otherwise you can just let @kshen0 review when the VxScan integration is done. |
eventualbuddha
force-pushed
the
pdi-rs
branch
from
45ca2c7
to
80dbe32
Compare
benadida
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
just from a TUI user perspective, as per @eventualbuddha 's request – I love having this and it looks powerful enough to test all the thing. 👍
|
Closing this out as we now have a proper integration and this CLI is now out of sync with main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Requires getting the kernel module and
libPDIScanshared library set up properly first. Needs a decent amount of cleanup and testing before we can merge this.To try it out,
cd libs/pdi-rs && cargo run --release. More comprehensive instructions here.Demo Video or Screenshot
Demo video where I start an auto-scan session and scan a single document:
pdi-cli-review.mov
Testing Plan