libs/hmpb cleanup #4882
Merged
libs/hmpb cleanup #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also create a `preview` dir for browser preview specific files
We don't support it in the VX ballot template, since we'll instead want to build a separate NH ballot template. I'd like to come up with a more general way to add custom parameters for ballot templates, so there's not much value in keeping this feature around.
The new VX ballot template doesn't support these parameters. My guess is that changing the bubble position will be state-specific and therefore be better implemented in a different template (rather than trying to have complex templates that support both bubble positions). Density may be a feature we want to implement, but if we do decide to keep it, I'd like to make it a template-specific parameter.
jonahkagan
force-pushed
the
jonah/hmpb-cleanup
branch
from
282cdeb
to
55b9a15
Compare
Most of these changes are rote, though I also updated the README and accidentally snuck those changes into this commit.
jonahkagan
force-pushed
the
jonah/hmpb-cleanup
branch
from
55b9a15
to
8de017f
Compare
eventualbuddha
approved these changes
May 28, 2024
|
I removed the old libraries from the required passing CI jobs. I'll add |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Task: #4559
Cleans up the unused code and code structure that resulted from implementing the new ballot rendering stack.
Notably, removes two features from VxDesign:
These are better implemented in the future as template-specific parameters.
More details in commits!
Demo Video or Screenshot
N/A
Testing Plan
Relying on automated tests. Plus did a manual test of impacted VxDesign features.
Checklist