Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tzp get (time zone period get) #107

Closed
Crafter-san opened this issue Mar 5, 2021 · 15 comments
Closed

add tzp get (time zone period get) #107

Crafter-san opened this issue Mar 5, 2021 · 15 comments

Comments

@Crafter-san
Copy link
Contributor

it basically either returns midnight, morning, evening, afternoon, or noon

@4Kaylum
Copy link
Member

4Kaylum commented Mar 5, 2021

Do you have issue reading the times in tz get?

@Crafter-san
Copy link
Contributor Author

Do you have issue reading the times in tz get?

Most of the time when I'm using tz get it's to check if it's morning or night or noon or afternoon or midnight for the person

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

What justifies adding it as its own command rather than just something in parentheses in the tz get command?

@Crafter-san
Copy link
Contributor Author

What justifies adding it as its own command rather than just something in parentheses in the tz get command?

More detail please

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

What detail do you need? I'm asking why you want to add it as its own command rather than an extension of what's already there.

@Crafter-san
Copy link
Contributor Author

What detail do you need? I'm asking why you want to add it as its own command rather than an extension of what's already there.

When I say I'm checking for the period of time, it means I'm trying to do at a glance, I don't wanna have to sift through a bunch of other content to get what I want

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

Other content being a few words? I'm not sure the difference between The current time for @Kae is estimated to be **1:01 AM**. and The current time for @Kae is estimated to be **1:01 AM**. It is the **night**. would be too much for you.

@Crafter-san
Copy link
Contributor Author

Other content being a few words? I'm not sure the difference between The current time for @Kae is estimated to be **1:01 AM**. and The current time for @Kae is estimated to be **1:01 AM**. It is the **night**. would be too much for you.

Are you saying this would be easy for the users or easy for you to implement?

@Crafter-san
Copy link
Contributor Author

Other content being a few words? I'm not sure the difference between The current time for @Kae is estimated to be **1:01 AM**. and The current time for @Kae is estimated to be **1:01 AM**. It is the **night**. would be too much for you.

Are you saying this would be easy for the users or easy for you to implement?

(not meant as an attack I just realized it sounds like it sorry)

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

I'm asking why you want it as a new command rather than an addition to what you have currently.

@Crafter-san
Copy link
Contributor Author

I'm asking why you want it as a new command rather than an addition to what you have currently.

It can be included in the current command, but I'd like a new command that just specifies the time period for when I don't have that much time to check but really wanna check

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

I don't see the value in a command that does nothing unique when an existing command shows exactly the same data.

@Crafter-san
Copy link
Contributor Author

I don't see the value in a command that does nothing unique when an existing command shows exactly the same data.

Then you choose if you want it in a separate command or in the same command, I'm not gonna argue anymore because I don't wanna disrespect you

@4Kaylum
Copy link
Member

4Kaylum commented Mar 6, 2021

PR it into the current command and I'll merge it.

@4Kaylum
Copy link
Member

4Kaylum commented Mar 13, 2021

Chris has now left the server and I'm not interested in adding this myself.

@4Kaylum 4Kaylum closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants