Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having two classes named Model #321

Open
brimoor opened this issue Oct 16, 2019 · 0 comments
Open

Avoid having two classes named Model #321

brimoor opened this issue Oct 16, 2019 · 0 comments
Labels
enhancement Code enhancement

Comments

@brimoor
Copy link
Contributor

brimoor commented Oct 16, 2019

It is confusing that we have two Model classes in ETA:

  • eta.core.learning.Model: abstract base class for loading and performing inference with models
  • eta.core.models.Model: Serializable class that describes a model, including its name, location of its model weights, and the default settings for using it

Perhaps we should rename eta.core.models.Model to eta.core.models.ModelDescription, to clarify that it describes a model and is not actually the model itself.

@brimoor brimoor added the enhancement Code enhancement label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

No branches or pull requests

1 participant