You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is confusing that we have two Model classes in ETA:
eta.core.learning.Model: abstract base class for loading and performing inference with models
eta.core.models.Model: Serializable class that describes a model, including its name, location of its model weights, and the default settings for using it
Perhaps we should rename eta.core.models.Model to eta.core.models.ModelDescription, to clarify that it describes a model and is not actually the model itself.
The text was updated successfully, but these errors were encountered:
It is confusing that we have two
Model
classes in ETA:eta.core.learning.Model
: abstract base class for loading and performing inference with modelseta.core.models.Model
: Serializable class that describes a model, including its name, location of its model weights, and the default settings for using itPerhaps we should rename
eta.core.models.Model
toeta.core.models.ModelDescription
, to clarify that it describes a model and is not actually the model itself.The text was updated successfully, but these errors were encountered: