Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoReaders need to be able to seek to specific frames #373

Open
jasoncorso opened this issue Dec 23, 2019 · 3 comments
Open

VideoReaders need to be able to seek to specific frames #373

jasoncorso opened this issue Dec 23, 2019 · 3 comments
Labels
feature Work on a feature request

Comments

@jasoncorso
Copy link
Contributor

This is a basic need that surprisingly has not arisen yet with the use of ETA, but there is no implemented support for video seeking. The underlying functionality in FFmpeg and OpenCV readers should already include this, which would just need to be wrapped.

@jasoncorso jasoncorso added the feature Work on a feature request label Dec 23, 2019
@brimoor
Copy link
Contributor

brimoor commented Dec 24, 2019

The way to seek now is via the frames argument of *VideoReader. But behind the scenes it reads frame-by-frame.

Since video readers support passing in arbitrary numbers of frame ranges of interest, the simplest optimization we could do is throw in an -ss flag to skip to the beginning of the first frame range and then read frame-by-frame from there.

@brimoor brimoor changed the title eta.core.video missing seek functionality on VideoReaders VideoReaders need to be able to seek and re-read videos Jan 2, 2020
@brimoor
Copy link
Contributor

brimoor commented Jan 2, 2020

Scope amended based on #383.

From @jasoncorso:

VideoReader will need to support seeking formally in order for this to work as modules may need to go back and forth or at the very least "reopen" a video

@brimoor brimoor changed the title VideoReaders need to be able to seek and re-read videos VideoReaders need to be able to seek to specific frames Jan 2, 2020
@brimoor
Copy link
Contributor

brimoor commented Jan 2, 2020

Scope back to just seek, in light of #384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on a feature request
Projects
None yet
Development

No branches or pull requests

2 participants