Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_config file not used by default #1734

Open
sbeaulie opened this issue Feb 17, 2022 · 3 comments
Open

ssh_config file not used by default #1734

sbeaulie opened this issue Feb 17, 2022 · 3 comments

Comments

@sbeaulie
Copy link
Contributor

sbeaulie commented Feb 17, 2022

Current code has an unexpected behavior:
https://github.com/voxpupuli/beaker/blob/master/lib/beaker/options/presets.rb#L197-L198

NET:SSH documentation sets it to true by default
https://net-ssh.github.io/net-ssh/classes/Net/SSH.html#method-c-start states

config => set to true to load the default OpenSSH config files (~/.ssh/config, /etc/ssh_config), or to false to not load them, or to a file-name (or array of file-names) to load those specific configuration files. Defaults to true.

Could we set it to true and optionally turn it off (current behavior) via an option flag? I don't think in most cases it would be a breaking change to respect the ssh_config file, but we could release a major version bump and document the change?

In my case it would be easier to have it default to true than having to change all the existing beaker usage specifically to turn it on via a new option flag.

@sbeaulie
Copy link
Contributor Author

@bastelfreak I'd like to get your opinion on this

@bastelfreak
Copy link
Member

bastelfreak commented Feb 23, 2022

theoretically it would be a breaking change and I am not sure about the impact. @ekohl do you have any thoughts on this?

Edit: I'm fine with making this configureable, but I'm unsure about the default value. Avoiding breaking changes is usually our approach, if possible.

@trevor-vaughan
Copy link
Contributor

I would definitely make it configurable but not change the default.

Beaker does a lot under the hood to ensure a clean connection to managed host clusters without interruption from outside sources. IMO the only time it should be set by default if you're targeting a non-manged host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants