Use common test suite?

[maxlinc]

There is a common test suite for implementors of JSON Schema validation libraries. It's being used by at least 15 validators now, but it doesn't look like it's setup for this project.

Are you interested in hooking up this suite, or did you already look at it and decide not to use it for some reason?

[apsoto]

+1

[pd]

I can't speak for @hoxworth, but I doubt there's any reason not to use it. I'd assume it's mostly just that this library significantly predates the common test suite, combined with not being aware of it / never having gotten around to implementing it.

👍 if you're willing to try your hand at it!

[maxlinc]

I'm willing to help hook it up and fix any issues. Definitely don't want to
go rogue and do it on my own, though!
On Aug 1, 2014 6:41 PM, "Kyle Hargraves" notifications@github.com wrote:

I can't speak for @hoxworth https://github.com/hoxworth, but I doubt
there's any reason not to use it. I'd assume it's mostly just that this
library significantly predates the common test suite, combined with not
being aware of it / never having gotten around to implementing it.

[image: 👍] if you're willing to try your hand at it!

—
Reply to this email directly or view it on GitHub
#113 (comment)
.

[hoxworth]

As @pd said, there is no opposition to integrating it at all. I do remember some discussion of the test suite a while back on the mailing list, but I tend to just casually subscribe to the mailing list due to the signal/noise ratio. Would love to have this in - if you want to do it, feel free, otherwise it will sit on the backlog with all the other things...

[mpalmer]

I got bored and put together some code for making this happen. PR #122 created.

[iainbeeston]

Should this be closed now?

[pd]

Thanks to everyone that made this happen!