Run json-schema.org's common test suite #122
Conversation
| require 'test/unit' | ||
| require File.expand_path('../../lib/json-schema', __FILE__) | ||
|
|
||
| class CommonTestSuiteTest < Test::Unit::TestCase |
There was a problem hiding this comment.
Could you change this to use two spaces rather than a tab (like the other tests?) #minor_point
This is good, because it's easier to debug a problem if you know *why* there's a problem.
mpalmer
force-pushed
the
common-test-suite
branch
from
4a32034
to
a247e28
Compare
|
@mpalmer thanks for doing this. I had started a branch adding the common test suite, but put it on the back burner as I ran into a couple of small issues. I'll look into this more later tonight / tomorrow morning, but I am not opposed to git submodules, as long as we keep them up-to-date. 😸 |
|
👍 If no one else has objections, I've left myself a note to come back and merge this early next week. I'd like to see some way to expose the remaining failing tests without breaking the build; something akin to rspec's |
As suggested by @pd.
|
@pd, I've just added another commit to this PR that implements skipping tests in files that are known to fail. |
|
I like this - I had spent some time trying to integrate the common test suite before you took this on. Going to merge with @pd 's input as well. |
Run json-schema.org's common test suite
Implementation of #113.
Straightforward generation of test cases based on the contents of the JSON-Schema-Test-Suite repo. I decided to go wild and add it as a git submodule; if that's not cool, then some other method of dealing with the problem can be devised. At least I hid all the insanit
^Wmagic behind the rake task, so nobody needs to deal with it by hand.