Don't ship spec directory, Rakefile or Gemfile in packaged modules
#680
Conversation
|
It might look innocent enough, but this is quite a big change. Even if you think this is a great idea, please don't merge just yet. But please leave feedback. |
There was a problem hiding this comment.
In Foreman's modulesync we do the same:
https://github.com/theforeman/foreman-installer-modulesync/blob/8e29149d17efd144371d5c46baff9f04fbb79141/moduleroot/.pmtignore.erb#L51
Haven't heard any complaints.
You may also want to drop the Gemfile and Rakefile.
alexjfisher
force-pushed
the
dont_package_spec
branch
from
a3e1420
to
ea1b9d1
Compare
alexjfisher
changed the title
spec directory in packaged modulesspec directory, Rakefile or Gemfile in packaged modules
Good plan. This also matches the PDK behaviour. |
|
Would you mind rebasing the PR? |
Don't ship the `spec` directory, `Gemfile`, or `Rakefile`. This should make the average module a fair bit smaller. PDK already does this by default. https://github.com/puppetlabs/pdk-templates/blob/172738acbf55e65afb1eb8541deb8bb242ca877b/config_defaults.yml#L57
alexjfisher
force-pushed
the
dont_package_spec
branch
from
ea1b9d1
to
c294770
Compare
This should make the average module a fair bit smaller.
PDK already does this by default.
https://github.com/puppetlabs/pdk-templates/blob/172738acbf55e65afb1eb8541deb8bb242ca877b/config_defaults.yml#L57