With Puppet 6 it is unable to use volume with dash in name

[scornelissen85]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.x
• Ruby: embedded with Puppet
• Distribution: RedHat
• Module version: 5.0.

How to reproduce (e.g Puppet code you use)

We use gluster::volume with title myname-vol1. Puppet code will fail because the dash is not allowed as variable. This issue exists since Puppet 6 because getvar() was before Puppet 6 from stdlib. In Puppet 6 it's a build in function.

The error will occur with a puppet run. The catalog failed to compile and an error message will be shown.

What are you seeing

This error message will appear:

The given string does not start with a valid variable name

What behaviour did you expect instead

A valid puppet run.

Output log

The given string does not start with a valid variable name

Any additional information you'd like to impart

I would like that title of gluster::volume would not be used to retrieve fact variable. I will try tomorrow to create a PR when I fixed the issue.