Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code in maifests/service.pp refers to code from manifests/params.pp #206

Closed
cavandavid opened this issue Apr 20, 2020 · 1 comment
Closed

Code in maifests/service.pp refers to code from manifests/params.pp #206

cavandavid opened this issue Apr 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@cavandavid
Copy link

BUG
I can see the old params.pp has been removed now, but there's still code that refers to it.

https://github.com/voxpupuli/puppet-grafana/blob/master/manifests/service.pp#L14

Evaluation Error: Unknown variable: 'grafana::params::docker_image'. (file: /etc/puppetlabs/code/envs/cavan/modules/upstream/grafana/manifests/service.pp, line: 14, column: 21) on node
@dhoppe dhoppe added the bug Something isn't working label Apr 20, 2020
@dhoppe
Copy link
Member

dhoppe commented Apr 20, 2020

Good catch. Are you able to provide a pull request?

@dhoppe dhoppe mentioned this issue May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhoppe @cavandavid